Add a version number to template cli #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseAbram
commented
Sep 11, 2024
| entropy-test-cli = { git="https://github.com/entropyxyz/entropy-core.git", branch = "programs-version" } |
There was a problem hiding this comment.
will change when merged
ameba23
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
This looks good.
The only thing i would want to change is that i currently don't see an easy way to know what version a program needs given its source code.
Either we should make the version number match the major or minor version of entropy-programs-core (which in turn should match that of entropy-programs-runtime).
Or we should have have a field in the template program's Cargo.toml which specifies which version number of the runtime this program is designed for, eg:
[package.metadata.entropy-program]
# The version number of the programs runtime
runtime-version = 0
HCastano
approved these changes
Sep 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with entropyxyz/entropy-core#1045