Move specific implementations of PaillierParams #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module Since the test params must have some values set to accommodate CGGMP requirements, which is out of scope of `paillier` submodule.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the test Paillier params must have some values set to accommodate CGGMP requirements, which is out of scope of
pailliersubmodule, they are now created in the same file as theSchemeParametersimpls. Thepailliersubmodule uses its own independent test params.It would be nice to gate test parameters under a feature, but
cargocurrently does not support enabling a feature by default for integration tests (see rust-lang/cargo#2911), and running integration tests with production parameters takes 10x more time - not too convenient for active development.