Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel 7+ support fix #93

Merged
merged 3 commits into from
Jun 23, 2018
Merged

Add babel 7+ support fix #93

merged 3 commits into from
Jun 23, 2018

Conversation

vihanb
Copy link
Contributor

@vihanb vihanb commented Jan 7, 2018

Fixes #92 and #78
Signed-off-by: Vihan contact@vihan.org

Signed-off-by: Vihan <contact@vihan.org>
@tomspeak
Copy link

tomspeak commented Feb 2, 2018

+1 would love this feature to be merged.

@michaelzoidl
Copy link
Member

Hey thanks for the PR :)
Can we keep both examples in the README? Each one with a headline e.g. Babel v6 and yours with the headline Babel v7?

Thanks for the contribution ✌️

@loyd
Copy link

loyd commented Mar 26, 2018

Bump )

@connorjclark
Copy link

Can this be merged?

Copy link

@billnbell billnbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please approve for Babel 7

@billnbell
Copy link

@michaelzoidl Please approve

Signed-off-by: Vihan <contact@vihan.org>
@michaelzoidl
Copy link
Member

Hey @vihanb,

thanks for contributing and sorry for the delay. Ok looks good, would it be possible to revert the renaming of the name in the package.json? :)

Also, seems there is a little conflict in the README (we've updated some things) could you resolve them?

Thanks.

Btw.. I'am searching for help in this project checkout #104

@vihanb
Copy link
Contributor Author

vihanb commented Jun 23, 2018

@michaelzoidl (@brigand I see you're a maintainer now too) sorry for late response, i have fixed conflict + package.json

brigand added a commit to brigand/babel-plugin-root-import that referenced this pull request Jun 23, 2018
@brigand
Copy link
Collaborator

brigand commented Jun 23, 2018

@vihanb thanks!

v6.1.0

@brigand brigand merged commit f7b114b into entwicklerstube:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants