Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs_command_alias should be set to "" when vcs_pr_comments_enabled is disabled #964

Closed
away168 opened this issue Oct 21, 2024 · 0 comments · Fixed by #965
Closed

vcs_command_alias should be set to "" when vcs_pr_comments_enabled is disabled #964

away168 opened this issue Oct 21, 2024 · 0 comments · Fixed by #965
Assignees
Labels
bug Something isn't working

Comments

@away168
Copy link

away168 commented Oct 21, 2024

Describe the bug
In a way while this could be a backend bug, the RnD team has asked to file this with the Provider.

When vcs_pr_comments_enabled is disabled; and the vcs_command_alias is still set - the environment service still thinks that the vcs_pr_comments is enabled and configured. Therefore it generates a "summary" in the git PR

To Reproduce
Create an environment with the provider; set vcs_command_alias="foo" and vcs_pr_comments_enabled=true

Then set vcs_pr_comments_enabled=false

Create a PR.
you'll see a pr_comment "header / summary" in the PR.

Expected behavior
PR Comment header or summary should not be created/added.

Provider Version
1.20.12

Screenshots
image

Additional context
Add any other context about the problem here.

@away168 away168 added the bug Something isn't working label Oct 21, 2024
@away168 away168 changed the title vcs_command_alias should be set to "" when vcs_pr_comments_enabled is disabled vcs_command_alias should be set to "" when vcs_pr_comments_enabled is disabled Oct 21, 2024
@TomerHeber TomerHeber self-assigned this Oct 21, 2024
@TomerHeber TomerHeber moved this from To do to In progress in Ongoing Issues Oct 21, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Ongoing Issues Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants