Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle drift #205 #219

Closed
wants to merge 13 commits into from
Closed

Fix handle drift #205 #219

wants to merge 13 commits into from

Conversation

samuel-br
Copy link
Contributor

@samuel-br samuel-br commented Feb 2, 2022

Issue & Steps to Reproduce / Feature Request

fixes #205

Solution

@samuel-br samuel-br self-assigned this Feb 2, 2022
@razbensimon
Copy link
Contributor

@samuel-br Yo!

just here to note that we had that PR to fix that for templates.
Also please note that on most of resources, probably need to fix it in the regular way as Arel mentioned here.
See these lines from aws TF provider for an example. 👈🏼

@samuel-br
Copy link
Contributor Author

@razbensimon yap, I looked over what you fixed before, but as you mentioned not all resources have isDeleted in response body, so my way here is to check err is 404, correct me if I wrong here please

@razbensimon razbensimon mentioned this pull request Feb 21, 2022
@samuel-br samuel-br closed this Mar 9, 2022
@yaronya yaronya deleted the fix-handle_drift-#205 branch April 17, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle drift - general
2 participants