Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix keyring deprecated issue for mac #123

Merged
merged 2 commits into from
Oct 16, 2023
Merged

fix keyring deprecated issue for mac #123

merged 2 commits into from
Oct 16, 2023

Conversation

0xmuralik
Copy link
Contributor

Description

Make install fails on mac with deprecated warnings

cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

Cosmos-sdk issue: cosmos/cosmos-sdk#5759
Reference PR: cosmos/cosmos-sdk#12576

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@9e4acae). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage        ?   55.26%           
=======================================
  Files           ?       24           
  Lines           ?     2260           
  Branches        ?        0           
=======================================
  Hits            ?     1249           
  Misses          ?      936           
  Partials        ?       75

anilcse
anilcse approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it effect any other distributions? cc @aleem1314

@anilcse anilcse merged commit a89b65b into envadiv:main Oct 16, 2023
2 of 3 checks passed
anilcse added a commit that referenced this pull request Oct 16, 2023
@anilcse @aleem1314
@chillyvee @0xmuralik @jim380 @atheeshp
v2.2.0 upgrade (#129)
d3e462a 
* feat: add v2.1 upgrade handler (#121)

* feat: add upgrade handler

* chore: fix bech32 error

* chore: fix typo

* feat: add ante handler to block account

* chore: fix vesting unlock time

* Update app/upgrades/v1/upgrade.go

Co-authored-by: Anil K <anil@vitwit.com>

* Update app/upgrades/v1/upgrade.go

Co-authored-by: Anil K <anil@vitwit.com>

* chore: add depgaurd config

* chore: update linter

* chore: try fixing linter

---------

Co-authored-by: Anil K <anil@vitwit.com>

* CV FIX: wasm snapshot (#124)

* Add Wasm to Snapshot

* Update app/app.go

---------

Co-authored-by: Anil K <anil@vitwit.com>

* fix keyring deprecated issue for mac (#123)

Co-authored-by: Anil K <anil@vitwit.com>

* chore: update docker to support wasmvm (#120)

Co-authored-by: Anil K <anil@vitwit.com>

* feat: add upgrade handler `v2.2.0` (#128)

* chore: add upgrade handler `v2.2.0`

* fix claim records

* update time

* fix panic

* changes

* add claim records from snapshots

* suggestions

* review changes

* review changes

* Update app/upgrades/v2.2.0/upgrade.go

* fix amount sim bug

* add logs

* log

* log

* Fix airdrop amounts

* fix build

* fix

* review changes

* Update x/claim/keeper/claim.go

* test calc

* small fix

* another handle

* handle more coin errors

* revert

* add snapshot1 data directly

* update data

* sub original claim allocation

* review changes

* Update app/upgrades/v2.2.0/upgrade.go

* update go.mod

---------

Co-authored-by: Anil K <anil@vitwit.com>
Co-authored-by: Anil K <anilcse@Anils-MacBook-Pro.local>

* Update .github/workflows/lint.yml

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com>
Co-authored-by: Bala Murali Krishna Komatireddy <krishna192reddy@gmail.com>
Co-authored-by: Jay Namsayin <31609693+jim380@users.noreply.github.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Anil K <anilcse@Anils-MacBook-Pro.local>
anilcse added a commit that referenced this pull request Oct 16, 2023
@anilcse @aleem1314
@chillyvee @0xmuralik @jim380 @atheeshp
Fix snapshots, workflows (#143)
5377e66 
* feat: add v2.1 upgrade handler (#121)

* feat: add upgrade handler

* chore: fix bech32 error

* chore: fix typo

* feat: add ante handler to block account

* chore: fix vesting unlock time

* Update app/upgrades/v1/upgrade.go

Co-authored-by: Anil K <anil@vitwit.com>

* Update app/upgrades/v1/upgrade.go

Co-authored-by: Anil K <anil@vitwit.com>

* chore: add depgaurd config

* chore: update linter

* chore: try fixing linter

---------

Co-authored-by: Anil K <anil@vitwit.com>

* CV FIX: wasm snapshot (#124)

* Add Wasm to Snapshot

* Update app/app.go

---------

Co-authored-by: Anil K <anil@vitwit.com>

* fix keyring deprecated issue for mac (#123)

Co-authored-by: Anil K <anil@vitwit.com>

* chore: update docker to support wasmvm (#120)

Co-authored-by: Anil K <anil@vitwit.com>

* feat: add upgrade handler `v2.2.0` (#128)

* chore: add upgrade handler `v2.2.0`

* fix claim records

* update time

* fix panic

* changes

* add claim records from snapshots

* suggestions

* review changes

* review changes

* Update app/upgrades/v2.2.0/upgrade.go

* fix amount sim bug

* add logs

* log

* log

* Fix airdrop amounts

* fix build

* fix

* review changes

* Update x/claim/keeper/claim.go

* test calc

* small fix

* another handle

* handle more coin errors

* revert

* add snapshot1 data directly

* update data

* sub original claim allocation

* review changes

* Update app/upgrades/v2.2.0/upgrade.go

* update go.mod

---------

Co-authored-by: Anil K <anil@vitwit.com>
Co-authored-by: Anil K <anilcse@Anils-MacBook-Pro.local>

* Update .github/workflows/lint.yml

---------

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com>
Co-authored-by: Bala Murali Krishna Komatireddy <krishna192reddy@gmail.com>
Co-authored-by: Jay Namsayin <31609693+jim380@users.noreply.github.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Anil K <anilcse@Anils-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleem1314 aleem1314 aleem1314 approved these changes

@anilcse anilcse anilcse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xmuralik @codecov-commenter @anilcse @aleem1314