Remove force: true from create_table #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
approved these changes
Jan 24, 2020
|
Thanks. Do you mind adding a line to the change log? |
|
I can, but that always seems to be where the merge conflicts crop up when I open a bunch of PRs on other repos ... Any chance you could merge the other open PRs and then I could do so? |
swrobel
force-pushed
the
no-force-in-migration
branch
from
776a016
to
12a7364
Compare
|
Done! |
|
Great. Actually, do you mind adding links to the PRs to resolve the rendering: [#178]: https://github.com/envato/double_entry/pull/178
[#181]: https://github.com/envato/double_entry/pull/181 |
swrobel
force-pushed
the
no-force-in-migration
branch
from
12a7364
to
56c602e
Compare
|
Oh yeah, I always forget there isn't some special magic that just knows to auto-link them. Done! |
swrobel
force-pushed
the
no-force-in-migration
branch
from
56c602e
to
ac80560
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been in the migration since the first commit, but I see no reason for it to be there (and it's generally considered unsafe, so it's better not to have it unless needed)
Context: this behavior is flagged by strong_migrations