Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check policy tags for ignore/include #22

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

andrewjhumphrey
Copy link
Contributor

4439076 (Andrew Humphrey)
Fetch Policy Tags

We want to be able to ignore policies as well as roles using our standard
tagging mechanisms. Tagging of policies is a relatively new feature, but
it is in general release. We need it to support programmatically generated
things like the roles and policies that Cloudwatch dashboards generates,
which add a random label at the end of the resource name, but a differently
formatted label than cloudwatch uses :-(

6d9d963 (Andrew Humphrey)
ListPolicyTags needs aws-sdk >= 1.37.10

We want to be able to ignore policies as well as roles using
our standard tagging mechanisms.  Tagging of policies is a
relatively new feature, but it is in general release.  We need
it to support programmatically generated things like the
roles and policies that Cloudwatch dashboards generates, which
add a random label at the end of the resource name, but a differently
formatted label than cloudwatch uses :-(
Copy link

@simpsora simpsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My untrained Go eye says 👍

@andrewjhumphrey andrewjhumphrey merged commit c840327 into main Jan 24, 2022
@simpsora simpsora deleted the andrewjhumphrey-fetch-policy-tags branch January 24, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants