Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error didn't surface very often as it required the GetRole call to fail.
The "normal" reason a GetRole fails is permission denied, which doesn't much happen in our context as folks run iamy using a privileged role.
Less common are network faults, like the one Bing experienced. Ignoring the error lead to an attempt to use memory that hadn't been allocated, with predictable consequences.
I've chosen to just panic if the role can't be retrieved as it means we don't have any information about that role and we don't want to save to disk or sync an incomplete state. We could theoretically add retry and backoff logic to the GetRole call and see this error occur less, but in the case of a PermissionDenied it doesn't matter how many times we retry, we're never going to get the information we need.