Add TypeScript definitions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdingena
added
enhancement
This reverts commit d4d08e2.
This should be a temporary solution until TypeScript officially supports ResizeObserver.
|
I'm now waiting on TypeScript 4.2 to be released, which includes interfaces for Scheduled for 23 February: microsoft/TypeScript#41601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We've added types to envato/react-breakpoints#8. Because its dependency on this package, we need to add types here as well for the exported code. An issue was raised for this: envato/react-breakpoints#11
Changes
Adds ResizeObserver interfaces by copying type definitions from @juggle/resize-observer. This polyfill is considered up-to-spec but I want to avoid adding it as a real dependency to this package for consumers. As an intermediate solution, I'm copying its type definitions until ResizeObserver API declarations missing microsoft/TypeScript#37861 is merged.