Fix restart bug with dynamic contracts #258
Merged
+258
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoPrest
commented
Oct 10, 2024
Comment on lines
-425
to
-429
| SELECT c.contract_address, c.contract_type, c.event_id, c.chain_id, c.block_timestamp | ||
| FROM "public"."dynamic_contract_registry" as c | ||
| JOIN raw_events e ON c.chain_id = e.chain_id | ||
| AND c.event_id = e.event_id | ||
| WHERE e.block_number <= ${block_number} AND e.chain_id = ${chainId};`; |
There was a problem hiding this comment.
There was a dependency on raw_events table for this start up query and raw_events became opt in from v2. So it's typically empty for most indexers.
There was a problem hiding this comment.
I got to you so it would lose those dynamic contracts on restart.
JonoPrest
commented
Oct 10, 2024
Comment on lines
+420
to
+427
| module.exports.readDynamicContractsOnChainIdBeforeEventId = ( | ||
| sql, | ||
| chainId, | ||
| block_number, | ||
| eventId, | ||
| ) => sql` | ||
| SELECT c.contract_address, c.contract_type, c.event_id, c.chain_id, c.block_timestamp | ||
| FROM "public"."dynamic_contract_registry" as c | ||
| JOIN raw_events e ON c.chain_id = e.chain_id | ||
| AND c.event_id = e.event_id | ||
| WHERE e.block_number <= ${block_number} AND e.chain_id = ${chainId};`; | ||
| SELECT * | ||
| FROM "public"."dynamic_contract_registry" | ||
| WHERE event_id < ${eventId} AND chain_id = ${chainId};`; |
There was a problem hiding this comment.
Now I construct the eventId of the next block and filter for anything below that ID so you end up with the desired effect
JasoonS
approved these changes
Oct 10, 2024
The SQL gets run and validated in the test when it calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic contract restart resistance has been broken since we removed
raw_eventsbeing required.