Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve warnings from Envoy during make test-extproc #274

Closed
mathetake opened this issue Feb 2, 2025 · 5 comments
Closed

Resolve warnings from Envoy during make test-extproc #274

mathetake opened this issue Feb 2, 2025 · 5 comments
Labels
help wanted Extra attention is needed test

Comments

@mathetake
Copy link
Member

mathetake commented Feb 2, 2025 •
edited
Loading

The following is the output from the command and I would like them resolved by updating https://github.com/envoyproxy/ai-gateway/blob/main/tests/extproc/envoy.yaml

[2025-02-02 10:36:10.185][40517516][warning][config] [source/common/listener_manager/listener_impl.cc:1054] reuse_port was configured for TCP listener '' and is being force disabled because Envoy is not running on Linux. See the documentation for more information.
[2025-02-02 10:36:10.189][40517516][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.extensions.access_loggers.file.v3.FileAccessLog Using deprecated option 'envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format' from file file.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.
[2025-02-02 10:36:10.193][40517516][warning][main] [source/server/server.cc:936] There is no configured limit to the number of allowed active downstream connections. Configure a limit in `envoy.resource_monitors.downstream_connections` resource monitor.

https://github.com/envoyproxy/ai-gateway/actions/runs/13096047563/job/36538439949
@mathetake mathetake added help wanted Extra attention is needed test labels Feb 2, 2025
@mathetake mathetake changed the title Resolve warnings from Envoy configuration during make test-extproc Resolve warnings from Envoy during make test-extproc Feb 2, 2025
@leseb
Copy link
Contributor

leseb commented Feb 3, 2025

I'm working on this and will send a PR shortly.

leseb added a commit to leseb/ai-gateway that referenced this issue Feb 3, 2025
@leseb
fix(envoy): resolve warnings in envoy.yaml
89074dc 
Addressed warnings observed during `make test-extproc`, except for the
`reuse_port` warning, which is platform-dependent and cannot be fixed on
non-Linux systems.

- Updated `json_format` to be nested under `log_format` to align with
  Envoy's expected configuration.
- Added `overload_manager` configuration to manage downstream
  connection limits.
- The warning related to `reuse_port` being force disabled on
  non-Linux platforms was **not** fixed, as it is platform-dependent.

Resolves: envoyproxy#274.
Signed-off-by: Sébastien Han <seb@redhat.com>
leseb added a commit to leseb/ai-gateway that referenced this issue Feb 3, 2025
@leseb
test: resolve warnings in envoy.yaml
6a00f9d 
Addressed warnings observed during `make test-extproc`, except for the
`reuse_port` warning, which is platform-dependent and cannot be fixed on
non-Linux systems.

- Updated `json_format` to be nested under `log_format` to align with
  Envoy's expected configuration.
- Added `overload_manager` configuration to manage downstream
  connection limits.
- The warning related to `reuse_port` being force disabled on
  non-Linux platforms was **not** fixed, as it is platform-dependent.

Resolves: envoyproxy#274.
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb mentioned this issue Feb 3, 2025
Merged
leseb added a commit to leseb/ai-gateway that referenced this issue Feb 3, 2025
@leseb
test: resolve warnings in envoy.yaml
268cff9 
Addressed warnings observed during `make test-extproc`, except for the
`reuse_port` warning, which is platform-dependent and cannot be fixed on
non-Linux systems.

- Updated `json_format` to be nested under `log_format` to align with
  Envoy's expected configuration.
- Added `overload_manager` configuration to manage downstream
  connection limits.
- The warning related to `reuse_port` being force disabled on
  non-Linux platforms was **not** fixed, as it is platform-dependent.

Resolves: envoyproxy#274.
Signed-off-by: Sébastien Han <seb@redhat.com>
mathetake pushed a commit that referenced this issue Feb 3, 2025
@leseb
test: resolve warnings in envoy.yaml (#283)
3ef7a48 
**Commit Message**

Addressed warnings observed during `make test-extproc`, except for the
`reuse_port` warning, which is platform-dependent and cannot be fixed on
non-Linux systems.

- Updated `json_format` to be nested under `log_format` to align with
Envoy's expected configuration.
- Added `overload_manager` configuration to manage downstream connection
limits.
- The warning related to `reuse_port` being force disabled on non-Linux
platforms was **not** fixed, as it is platform-dependent.

Signed-off-by: Sébastien Han <seb@redhat.com>

**Related Issues/PRs (if applicable)**

#274

**Special notes for reviewers (if applicable)**

The warning related to `reuse_port` being force disabled on non-Linux
platforms was **not** fixed, as it is platform-dependent. Any
suggestions for a fix are welcome.

Signed-off-by: Sébastien Han <seb@redhat.com>
@mathetake
Copy link
Member Author

@leseb if you have a mac locally, could you take a look at this mac specific warning as well?

[2025-02-02 10:36:10.185][40517516][warning][config] [source/common/listener_manager/listener_impl.cc:1054] reuse_port was configured for TCP listener '' and is being force disabled because Envoy is not running on Linux. See the documentation for more information.

@leseb
Copy link
Contributor

leseb commented Feb 3, 2025

@mathetake Since the option behaves differently depending on the platform, I’m not sure if we can suppress this warning on Mac. Also, I don’t want to alter Linux’s default behavior just to silence it on Mac. One possibility is to use separate files for Linux and Mac by using a template to generate the file based on the OS, but that feels excessive. If you have any suggestions, I’m open to them—but honestly, I might just let this one go.

@mathetake
Copy link
Member Author

Sounds reasonable - let's close this for now then

@leseb
Copy link
Contributor

leseb commented Feb 3, 2025

Fixed in #283.

ericmariasis pushed a commit to ericmariasis/ai-gateway that referenced this issue Feb 7, 2025
@leseb @ericmariasis
test: resolve warnings in envoy.yaml (envoyproxy#283)
6d1fc67 
**Commit Message**

Addressed warnings observed during `make test-extproc`, except for the
`reuse_port` warning, which is platform-dependent and cannot be fixed on
non-Linux systems.

- Updated `json_format` to be nested under `log_format` to align with
Envoy's expected configuration.
- Added `overload_manager` configuration to manage downstream connection
limits.
- The warning related to `reuse_port` being force disabled on non-Linux
platforms was **not** fixed, as it is platform-dependent.

Signed-off-by: Sébastien Han <seb@redhat.com>

**Related Issues/PRs (if applicable)**

envoyproxy#274

**Special notes for reviewers (if applicable)**

The warning related to `reuse_port` being force disabled on non-Linux
platforms was **not** fixed, as it is platform-dependent. Any
suggestions for a fix are welcome.

Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Eric Mariasis <ericmariasis829@gmail.com>
missBerg pushed a commit to melsal13/ai-gateway that referenced this issue Feb 9, 2025
@leseb @missBerg
test: resolve warnings in envoy.yaml (envoyproxy#283)
7787787 
**Commit Message**

Addressed warnings observed during `make test-extproc`, except for the
`reuse_port` warning, which is platform-dependent and cannot be fixed on
non-Linux systems.

- Updated `json_format` to be nested under `log_format` to align with
Envoy's expected configuration.
- Added `overload_manager` configuration to manage downstream connection
limits.
- The warning related to `reuse_port` being force disabled on non-Linux
platforms was **not** fixed, as it is platform-dependent.

Signed-off-by: Sébastien Han <seb@redhat.com>

**Related Issues/PRs (if applicable)**

envoyproxy#274

**Special notes for reviewers (if applicable)**

The warning related to `reuse_port` being force disabled on non-Linux
platforms was **not** fixed, as it is platform-dependent. Any
suggestions for a fix are welcome.

Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leseb @mathetake