e2e: update/fix extproc test #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexa Griffith <agriffith96@gmail.com>
Signed-off-by: Alexa Griffith <agriffith96@gmail.com>
alexagriffith
changed the title
mathetake
requested changes
Feb 7, 2025
Comment on lines
+113
to
+115
| if tc.testCaseName == "openai" && openAIAPIKey == "" { | ||
| t.Skip("Skipping openai test case as TEST_OPENAI_API_KEY is not set") | ||
| } |
There was a problem hiding this comment.
please do not specialize openai. what happens when we are adding more providers? what about someone wanting to test openai but not aws? Can you simply add a env var requirement check and skip each case accordingly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
make fixes to current test file