Skip to content

Commit

Permalink
Enhance comment about MonotonicTime (#8011)
Browse files Browse the repository at this point in the history
Depending on the execution environment in which envoy is being run, it
is possible that some of the assumption on the clock are maybe not
holding as previously commented. With some sandboxing technologies the
clock does not reference the machine boot time but the sandbox boot
time. This invalidates the assumtpion that the first update in the
cluster_manager will most likely fall out of the windows and ends up
showing a non intuitive behavior difficult to catch.
This PR simply adds a comment that will allow the reader to consider
this option while reading to the code.

Signed-off-by: Flavio Crisciani <f.crisciani@gmail.com>

Mirrored from https://github.com/envoyproxy/envoy @ 640b5a436d2ce8e637d28225d5b4f0aae307dede
  • Loading branch information
data-plane-api(CircleCI) committed Aug 23, 2019
1 parent 46d6aaf commit 3337c67
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion envoy/api/v2/cds.proto
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,8 @@ message Cluster {
// the first update happens. This is useful for big clusters, with potentially noisy deploys
// that might trigger excessive CPU usage due to a constant stream of healthcheck state changes
// or metadata updates. The first set of updates to be seen apply immediately (e.g.: a new
// cluster).
// cluster). Please always keep in mind that the use of sandbox technologies may change this
// behavior.
//
// If this is not set, we default to a merge window of 1000ms. To disable it, set the merge
// window to 0.
Expand Down

0 comments on commit 3337c67

Please sign in to comment.