Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: core envoy #11

Closed
junr03 opened this issue Apr 11, 2019 · 4 comments
Closed

transport: core envoy #11

junr03 opened this issue Apr 11, 2019 · 4 comments
Assignees
Milestone

Comments

@junr03
Copy link
Member

junr03 commented Apr 11, 2019

Proposal for refactoring in core envoy to allow for seamless use of transport in iOS and Android as well as current server mode.

@junr03 junr03 self-assigned this Apr 11, 2019
@junr03 junr03 transferred this issue from another repository May 2, 2019
@junr03 junr03 added the core label May 2, 2019
@junr03 junr03 added this to the v0.2 "Primo" milestone May 2, 2019
@stale
Copy link

stale bot commented Jun 2, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 2, 2019
@junr03 junr03 removed stale labels Jun 3, 2019
@stale
Copy link

stale bot commented Aug 2, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 2, 2019
@stale
Copy link

stale bot commented Aug 9, 2019

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Aug 9, 2019
@junr03 junr03 removed the stale label Sep 6, 2019
@junr03
Copy link
Member Author

junr03 commented Sep 6, 2019

this is done for 0.2 as part of the Direct API

jpsim added a commit that referenced this issue Apr 22, 2022
This was causing hangs/crashes in our Lyft apps so I'm reverting this
while I continue to investigate.

Here's the crash backtrace I'm seeing on iOS (not very helpful
unfortunately):

```
* thread #11, stop reason = signal SIGABRT
  * frame #0: 0x000000013a02300e libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00000001399a61ff libsystem_pthread.dylib`pthread_kill + 263
    frame #2: 0x0000000138905684 libsystem_c.dylib`abort + 123
    frame #3: 0x00000001024793af Lyft`___lldb_unnamed_symbol4253$$Lyft + 3231
    frame #4: 0x000000010247e0c7 Lyft`___lldb_unnamed_symbol4339$$Lyft + 130
    frame #5: 0x00000001399a64e1 libsystem_pthread.dylib`_pthread_start + 125
    frame #6: 0x00000001399a1f6b libsystem_pthread.dylib`thread_start + 15
```

This breaks h3 functionality, which merged yesterday and is as of yet
unused.

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants