Migrate to Bazel 5.0.0 #2034
Merged
Migrate to Bazel 5.0.0 #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
* main: [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030) Enable the "received byte count" feature. (envoyproxy#2004) Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
by changing the URL for the zip archive Signed-off-by: JP Simard <jp@jpsim.com>
Last commit before moving to Bazel 5.0.0 Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Following the instructions in https://github.com/bazelbuild/bazel-toolchains Specifically: $ ./rbe_configs_gen \ --bazel_version="5.0.0" \ --toolchain_container="docker.io/envoyproxy/envoy-build-ubuntu:514e2f7bc36c1f0495a523b16aab9168a4aa13b6" \ --exec_os="linux" \ --target_os="linux" \ --output_src_root="/path/to/envoy-mobile" \ --output_config_path="third_party/rbe_configs" \ --cpp_env_json=clang.json \ --generate_java_configs=False $ cat clang.json {"CC": "/opt/llvm/bin/clang", "CXX": "/opt/llvm/bin/clang++"} Signed-off-by: JP Simard <jp@jpsim.com>
* origin/main: [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
* main: envoy: 71248e512 (envoyproxy#2027) Migrate EngFlow configurations from rbe_autoconfig to rbe_configs_gen (envoyproxy#2037) timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) Signed-off-by: JP Simard <jp@jpsim.com>
and point to more representative GitHub issue. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
keith
previously approved these changes
Feb 3, 2022
Bencodes
reviewed
Feb 3, 2022
| @@ -16,10 +16,6 @@ build --spawn_strategy=local | |||
| build --verbose_failures | |||
| build --workspace_status_command=envoy/bazel/get_workspace_status | |||
| build --xcode_version=13.2.1 | |||
| build --host_javabase=@bazel_tools//tools/jdk:remote_jdk11 | |||
There was a problem hiding this comment.
There is a new way to provide these values on Bazel 5.0 if you want to preserve this. At minimum you might want to provide the java_language_version and tool_java_language_version just to make sure that it's consistent moving forward.
Ex:
build \
--java_language_version=8 \
--tool_java_language_version=8 \
--java_runtime_version=lyft_jdk11 \
--tool_java_runtime_version=lyft_jdk11
There was a problem hiding this comment.
These are actually defined in Envoy now, and we import that .bazelrc file: https://github.com/envoyproxy/envoy/blob/708742e9e8ec44e634a02d16eee0dce826130298/.bazelrc#L19-L20
This works around https://github.com/bazelbuild/bazel/issues/14260 This is based on tensorflow's implementation https://github.com/tensorflow/tensorflow/tree/34c03ed67692eb76cb3399cebca50ea8bcde064c/third_party/android Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remotejdk_11configurations in .bazelrc which we now inherit from Envoyandroid_ndk_repositoryis fetched eagerly bazelbuild/rules_android_ndk#92 androidndk fetching issue