Cronvoy: Map EM Errors to Cronet API Errors II (#1594) #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chidera Olibie <colibie@google.com>
The mockurlrequestmock tests are not useful because the different FailurPhases being tested are not used anywhere in the code. Also deleted FailurePhase as it's also unneeded Signed-off-by: Chidera Olibie <colibie@google.com>
This was due to running two engines simultaneously which not yet fully support(Issue envoyproxy#332) Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
colibie
commented
Oct 25, 2022
library/java/org/chromium/net/impl/CronetBidirectionalStream.java
Outdated
Show resolved
Hide resolved
|
@Danstahrg for cronet review |
colibie
changed the title
Danstahrg
reviewed
Oct 25, 2022
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Danstahrg
approved these changes
Oct 26, 2022
Danstahrg
previously approved these changes
Oct 27, 2022
Signed-off-by: Chidera Olibie <colibie@google.com>
|
@RyanTheOptimist for EM review and merge |
library/java/org/chromium/net/impl/CronetBidirectionalStream.java
Outdated
Show resolved
Hide resolved
use named constant for quic error also and return internet_disconnected error before quic_error Signed-off-by: Chidera Olibie <colibie@google.com>
RyanTheOptimist
approved these changes
Nov 2, 2022
jpsim
added a commit
that referenced
this pull request
Nov 4, 2022
…builder-function * origin/main: remove the use of deprecated flag (#2658) Cronvoy: Map EM Errors to Cronet API Errors II (#1594) (#2633) build: revert boring patch (#2651) Bump Lyft Support Rotation (#2654) fix one issue blocking bumping Envoy (#2649) ci: remove Snow from Lyft EM rotation (#2650) ci: increasing timeouts (#2653) python: Apply Envoy python-yapf formatting (#2648) repo: Shellcheck cleanups (#2646) repo: Switch `pip_install` -> `pip_parse` (#2647) Use safe_malloc instead of new when creating new_envoy_map_entry (#2632) python: Pin requirement hashes (#2643) Disable flaky TestConfig.StringAccessors (#2642) ci: migrate from set-output to GITHUB_OUTPUT (#2625) Add a comment to addPlatformFilter (#2634) Allow Cronvoy to build with proguard. (#2635) Update Envoy (#2630) Add support for Platform and Native filters to C++ EngineBuilder (#2626) Register getaddrinfo in extension_registry (#2627) dns: stop using cares DNS resolver (#2618) Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: As a follow up for PR2568, the PR maps the network_disconnected and quic exception errors. The network_changed error has been removed as this is not relevant to envoymobile.
Risk Level: Low
Testing: Included
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]