This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
implement declare_property #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
Will need to cherry pick on istio/envoy after merge. |
jplevyak
approved these changes
Apr 15, 2020
| @@ -266,6 +269,14 @@ class Context : public proxy_wasm::ContextBase, | |||
| absl::optional<google::api::expr::runtime::CelValue> | |||
| FindValue(absl::string_view name, Protobuf::Arena* arena) const override; | |||
| bool IsPathUnknown(absl::string_view) const override { return false; } | |||
| const std::vector<google::api::expr::runtime::CelAttributePattern>& | |||
There was a problem hiding this comment.
Consider a using declaration for CellAttributePattern
There was a problem hiding this comment.
This should go away once I get cel-cpp updated. I had difficulty merging the base class definitions.
| if (initialized_) { | ||
| switch (type_) { | ||
| case WasmType::String: | ||
| return google::api::expr::runtime::CelValue::CreateString(&value_); |
There was a problem hiding this comment.
Consider a using declaration.
test/extensions/filters/http/wasm/test_data/null_plugin/plugin.cc
Outdated
Show resolved
Hide resolved
|
@PiotrSikora do you have any comments? |
Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov
added a commit
to istio/envoy
that referenced
this pull request
Apr 17, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
howardjohn
pushed a commit
to istio/envoy
that referenced
this pull request
Apr 17, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Implements
declare_propertyFFI.Fixes #479
The following is a canonical example:
declare_property(x, { serialized schema })set_property({"x"}, { serialized content })get_property({"x", "y"}, &value)Changes:
Getting a filter state property requires using the same path used in set_property. This is simpler, and cleaner.