Skip to content

Commit

Permalink
cleanup: remove stale todos (#396)
Browse files Browse the repository at this point in the history
Description: remove todos that were done already.
Risk Level: low

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
  • Loading branch information
junr03 authored and jpsim committed Nov 28, 2022
1 parent 525e1e6 commit 34f5433
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions mobile/library/common/buffer/utility.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ namespace Utility {
Buffer::InstancePtr toInternalData(envoy_data data) {
// This fragment only needs to live until done is called.
// Therefore, it is sufficient to allocate on the heap, and delete in the done method.
// TODO: this method leaks the implementation of Buffer::BridgeFragment and could be improved to
// avoid new.
Buffer::BridgeFragment* fragment = Buffer::BridgeFragment::createBridgeFragment(data);
InstancePtr buf = std::make_unique<Buffer::OwnedImpl>();
buf->addBufferFragment(*fragment);
Expand Down
4 changes: 0 additions & 4 deletions mobile/library/common/http/dispatcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ class Dispatcher : public Logger::Loggable<Logger::Id::http> {
envoy_status_t sendData(envoy_stream_t stream, envoy_data data, bool end_stream);
envoy_status_t sendMetadata(envoy_stream_t stream, envoy_headers headers, bool end_stream);
envoy_status_t sendTrailers(envoy_stream_t stream, envoy_headers headers);
// TODO: when implementing this function we have to make sure to prevent races with already
// scheduled and potentially scheduled callbacks. In order to do so the platform callbacks need to
// check for atomic state (boolean most likely) that will be updated here to mark the stream as
// closed.
envoy_status_t resetStream(envoy_stream_t stream);

private:
Expand Down
2 changes: 0 additions & 2 deletions mobile/test/common/http/dispatcher_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -587,8 +587,6 @@ TEST_F(DispatcherTest, ResetInOnHeaders) {
EXPECT_CALL(stream_callbacks_, onReset());

response_decoder_->decodeHeaders(HeaderMapPtr(new TestHeaderMapImpl{{":status", "200"}}), false);
// TODO: Need to finish the data side (sendData, onData) in order to fully verify that onData was
// never called due to the reset.
}

TEST_F(DispatcherTest, StreamTimeout) {
Expand Down

0 comments on commit 34f5433

Please sign in to comment.