Improve build rules for (test only) library quic_port_utils. (#6672)

Improve build rules for (test only) library quic_port_utils, by removing the intermediate library //extensions/quic_listeners/quiche/platform:quic_platform_port_utils_impl_lib. Risk Level: none, build only Testing: bazel test --test_output=all test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all bazel test --test_output=all --define quiche=enabled test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all Signed-off-by: Bin Wu <wub@google.com>
envoyproxy · Apr 23, 2019 · 478e734 · 478e734
1 parent 0e89879
commit 478e734
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 30 deletions.
diff --git a/bazel/external/quiche.BUILD b/bazel/external/quiche.BUILD
@@ -155,15 +155,9 @@ cc_library(
 cc_library(
     name = "quic_platform_port_utils",
     testonly = 1,
-    hdrs = envoy_select_quiche(
-        ["quiche/quic/platform/api/quic_port_utils.h"],
-        "@envoy",
-    ),
+    hdrs = ["quiche/quic/platform/api/quic_port_utils.h"],
     visibility = ["//visibility:public"],
-    deps = envoy_select_quiche(
-        ["@envoy//source/extensions/quic_listeners/quiche/platform:quic_platform_port_utils_impl_lib"],
-        "@envoy",
-    ),
+    deps = ["@envoy//test/extensions/quic_listeners/quiche/platform:quic_platform_port_utils_impl_lib"],
 )
 
 cc_library(

diff --git a/bazel/external/quiche.genrule_cmd b/bazel/external/quiche.genrule_cmd
@@ -18,6 +18,9 @@ src_base_dir=$$(dirname $$(dirname $$(dirname $(rootpath quic/core/quic_constant
 
 # sed commands to apply to each source file.
 cat <<EOF >sed_commands
+# Rewrite include directives for testonly platform impl files.
+/^#include/ s!net/quic/platform/impl/quic_port_utils_impl.h!test/extensions/quic_listeners/quiche/platform/quic_port_utils_impl.h!
+
 # Rewrite include directives for platform impl files.
 /^#include/ s!net/(http2|spdy|quic)/platform/impl/!extensions/quic_listeners/quiche/platform/!
 

diff --git a/source/extensions/quic_listeners/quiche/platform/BUILD b/source/extensions/quic_listeners/quiche/platform/BUILD
@@ -66,13 +66,6 @@ envoy_cc_library(
     visibility = ["//visibility:public"],
 )
 
-envoy_cc_test_library(
-    name = "quic_platform_port_utils_impl_lib",
-    hdrs = ["quic_port_utils_impl.h"],
-    include_prefix = "extensions/quic_listeners/quiche/platform",
-    deps = ["//test/extensions/quic_listeners/quiche/platform:quic_platform_port_utils_test_impl_lib"],
-)
-
 envoy_cc_library(
     name = "quic_platform_logging_impl_lib",
     srcs = ["quic_logging_impl.cc"],

diff --git a/source/extensions/quic_listeners/quiche/platform/quic_port_utils_impl.h b/source/extensions/quic_listeners/quiche/platform/quic_port_utils_impl.h
diff --git a/test/extensions/quic_listeners/quiche/platform/BUILD b/test/extensions/quic_listeners/quiche/platform/BUILD
@@ -55,9 +55,9 @@ envoy_cc_test(
 )
 
 envoy_cc_test_library(
-    name = "quic_platform_port_utils_test_impl_lib",
-    srcs = ["quic_port_utils_test_impl.cc"],
-    hdrs = ["quic_port_utils_test_impl.h"],
+    name = "quic_platform_port_utils_impl_lib",
+    srcs = ["quic_port_utils_impl.cc"],
+    hdrs = ["quic_port_utils_impl.h"],
     deps = [
         "//source/common/network:utility_lib",
         "//test/test_common:environment_lib",

diff --git a/...che/platform/quic_port_utils_test_impl.cc → ...s/quiche/platform/quic_port_utils_impl.cc b/...che/platform/quic_port_utils_test_impl.cc → ...s/quiche/platform/quic_port_utils_impl.cc
@@ -4,7 +4,7 @@
 // consumed or referenced directly by other Envoy code. It serves purely as a
 // porting layer for QUICHE.
 
-#include "test/extensions/quic_listeners/quiche/platform/quic_port_utils_test_impl.h"
+#include "test/extensions/quic_listeners/quiche/platform/quic_port_utils_impl.h"
 
 #include "envoy/network/address.h"
 

diff --git a/...iche/platform/quic_port_utils_test_impl.h → ...rs/quiche/platform/quic_port_utils_impl.h b/...iche/platform/quic_port_utils_test_impl.h → ...rs/quiche/platform/quic_port_utils_impl.h