more

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
envoyproxy · Nov 26, 2024 · 60d574c · 60d574c
1 parent 6c1314d
commit 60d574c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/source/common/common/utility.cc b/source/common/common/utility.cc
@@ -589,12 +589,12 @@ void StringUtil::escapeToOstream(std::ostream& os, absl::string_view view) {
 std::string StringUtil::sanitizeInvalidHostname(const absl::string_view source) {
   std::string ret_str = std::string(source);
   bool sanitized = false;
-  for (char i : ret_str) {
+  for (char& i : ret_str) {
     if (absl::ascii_isalnum(i) || i == '.' || i == '-' || i == '_') {
       continue;
     }
     sanitized = true;
-    ret_str[i] = '_';
+    i = '_';
   }
 
   if (sanitized) {