Skip to content

Commit

Permalink
Docs: Add diagram for histogram stat sink. (#32665)
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Baichoo <envoy@kevinbaichoo.com>
  • Loading branch information
KBaichoo authored Mar 4, 2024
1 parent ae11b93 commit a2673f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Binary file added source/docs/histogram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions source/docs/stats.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ followed.
accumulates in to *interval* histograms.
* Finally the main *interval* histogram is merged to *cumulative* histogram.

Pictorially this looks like:

![Histogram Stat Flush](histogram.png)

`ParentHistogram`s are held weakly a set in ThreadLocalStore. Like other stats,
they keep an embedded reference count and are removed from the set and destroyed
when the last strong reference disappears. Consequently, we must hold a lock for
Expand Down

0 comments on commit a2673f7

Please sign in to comment.