reviewer comments

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

api/envoy/config/filter/network/tcp_proxy/v2/tcp_proxy.proto

@@ -113,6 +113,8 @@ message TcpProxy {
  // Configuration for tunneling TCP over other transports or application layers.
  // Currently, only HTTP/2 is supported. When other options exist, HTTP/2 will
  // remain the default.
+ // Note that CONNECT support is currently considered alpha in Envoy.
+ // [#comment:TODO(htuch): Replace the above comment with an alpha tag.
  message TunnelingConfig {
  // The hostname to send in the synthesized CONNECT headers to the upstream proxy.
  string hostname = 1 [(validate.rules).string = {min_bytes: 1}];

api/envoy/config/route/v3/route_components.proto

@@ -433,6 +433,8 @@ message RouteMatch {
  // This is the only way to match CONNECT requests for HTTP/1.1. For HTTP/2,
  // where CONNECT requests may have a path, the path matchers will work if
  // there is a path present.
+ // Note that CONNECT support is currently considered alpha in Envoy.
+ // [#comment:TODO(htuch): Replace the above comment with an alpha tag.
  ConnectMatcher connect_matcher = 12;
  }
 
@@ -737,6 +739,8 @@ message RouteAction {
 
  // Configuration for sending data upstream as a raw data payload. This is used for
  // CONNECT requests, when forwarding CONNECT payload as raw TCP.
+ // Note that CONNECT support is currently considered alpha in Envoy.
+ // [#comment:TODO(htuch): Replace the above comment with an alpha tag.
  ConnectConfig connect_config = 3;
  }
 

api/envoy/config/route/v4alpha/route_components.proto

@@ -436,6 +436,8 @@ message RouteMatch {
  // This is the only way to match CONNECT requests for HTTP/1.1. For HTTP/2,
  // where CONNECT requests may have a path, the path matchers will work if
  // there is a path present.
+ // Note that CONNECT support is currently considered alpha in Envoy.
+ // [#comment:TODO(htuch): Replace the above comment with an alpha tag.
  ConnectMatcher connect_matcher = 12;
  }
 
@@ -743,6 +745,8 @@ message RouteAction {
 
  // Configuration for sending data upstream as a raw data payload. This is used for
  // CONNECT requests, when forwarding CONNECT payload as raw TCP.
+ // Note that CONNECT support is currently considered alpha in Envoy.
+ // [#comment:TODO(htuch): Replace the above comment with an alpha tag.
  ConnectConfig connect_config = 3;
  }
 

docs/root/intro/arch_overview/http/upgrades.rst

@@ -96,7 +96,7 @@ An example set up proxying SMTP would look something like this
 
 [SMTP Upstream] --- raw SMTP --- [L2 Envoy] --- SMTP tunneled over HTTP/2 --- [L1 Envoy] --- raw SMTP --- [Client]
 
-Examples of such a set up can be found in the Envoy example config `directory <https://github.com/envoyproxy/envoy/tree/master/configs/>`
+Examples of such a set up can be found in the Envoy example config :repo:`directory <configs/>`
 If you run `bazel-bin/source/exe/envoy-static --config-path configs/encapsulate_in_connect.yaml --base-id 1`
 and `bazel-bin/source/exe/envoy-static --config-path configs/terminate_connect.yaml`
 you will be running two Envoys, the first listening for TCP traffic on port 10000 and encapsulating it in an HTTP/2