Major version selection for non-xDS services #10609
Labels
Comments
htuch
added
api/v3
Closed
|
Tagging for collection in #10943 |
8 tasks
htuch
pushed a commit
that referenced
this issue
Jun 19, 2020
#11583) This patch allows configuring the API version for gRPC external services. This specifies the version of the endpoint and message to be used. Affected extensions: - filters/http/ext_authz - filters/network/ext_authz - filters/http/ratelimit - filters/network/ratelimit - access_loggers/grpc - stat_sinks/metrics_service Affected upstream services: - upstream/health_discovery_service - upstream/load_stats_reporter Additional Description: tap - TapSinkService is not yet implemented. - TapDiscoveryService uses theconfig.core.v3.ApiConfigSource and is not yet implemented. trace - StreamTraces has no implemented client inside the code-base (implemented externally?) Risk Level: Low Testing: Added. Docs Changes: Added. Release Notes: Added. Fixes #10609 Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
songhu
pushed a commit
to songhu/envoy
that referenced
this issue
Jun 25, 2020
envoyproxy#11583) This patch allows configuring the API version for gRPC external services. This specifies the version of the endpoint and message to be used. Affected extensions: - filters/http/ext_authz - filters/network/ext_authz - filters/http/ratelimit - filters/network/ratelimit - access_loggers/grpc - stat_sinks/metrics_service Affected upstream services: - upstream/health_discovery_service - upstream/load_stats_reporter Additional Description: tap - TapSinkService is not yet implemented. - TapDiscoveryService uses theconfig.core.v3.ApiConfigSource and is not yet implemented. trace - StreamTraces has no implemented client inside the code-base (implemented externally?) Risk Level: Low Testing: Added. Docs Changes: Added. Release Notes: Added. Fixes envoyproxy#10609 Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this issue
Jul 24, 2020
envoyproxy#11583) This patch allows configuring the API version for gRPC external services. This specifies the version of the endpoint and message to be used. Affected extensions: - filters/http/ext_authz - filters/network/ext_authz - filters/http/ratelimit - filters/network/ratelimit - access_loggers/grpc - stat_sinks/metrics_service Affected upstream services: - upstream/health_discovery_service - upstream/load_stats_reporter Additional Description: tap - TapSinkService is not yet implemented. - TapDiscoveryService uses theconfig.core.v3.ApiConfigSource and is not yet implemented. trace - StreamTraces has no implemented client inside the code-base (implemented externally?) Risk Level: Low Testing: Added. Docs Changes: Added. Release Notes: Added. Fixes envoyproxy#10609 Signed-off-by: Dhi Aurrahman <dio@tetrate.io> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we only support major version selection for xDS transport/resource versions. Other services have hardcoded service endpoints, e.g.
envoy.service.accesslog.v2.AccessLogService.StreamAccessLogs.These services are (at least):
We should plumb appropriate service selection configuration for each gRPC service, scrub newer fields when sending to older versions, and audit to ensure that the older deprecated fields remain set (and are scrubbed when sent to newer versions that no longer support them).
See also the thread in #10355 (comment)
CC @yuval-k @envoyproxy/api-shepherds
The text was updated successfully, but these errors were encountered: