-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Envoy config no longer works #17105
Comments
huh. think we should just switch back to google? I'm not sure what prompted the change but we have to use google for the equivalent HTTP/3 config (since envoyproxy doesn't have that turned up) so it'd both work and be consistent |
preferably not - apart from anything else it would be good to know why it doesnt work
2 reasons iirc
hmm - i guess in that case its necessary - but in a way it would be good if we could point it to a neutral reference server |
or maybe a smiley welcome page on something like |
cloudflare has quic/http3 support https://blog.cloudflare.com/http3-the-past-present-and-future/ so we could do it with that |
checking this further... there is an http3 downstream - which proxies to envoy - which i struggled to get working - but even if i had i guess it will hit the same issue raised here there is an http3 upstream - which works (doesnt even bork wierdly) proxying via http3 as an aside it would be v good to get some http3 sandboxes set up im gonna mark this high priority - because the docs and docker image are kinda broken - and its a blocker for building system packages #16899 |
before we fix this @alyssawilk it would be good to add xfailing test/s #17145 is related but i think possibly we just want to test all of the configs in the ill do some testing and try and figure out a way forward |
im not sure if this has been fixed, or if something changed upstream - it was always a flake in the sense that sometimes it worked and sometimes not - but my understanding was that it wouldnt be fixed until #17070 landed i have tested the default config again with the current |
Adding the option to override scheme Risk Level: low (config guarded code) Testing: unit testing Docs Changes: n/a Release Notes: inline Part of envoyproxy#14587 Fixes envoyproxy#17105 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
description
sometime ago we switched the default Envoy config (eg included in the docker images) from pointing to google.com -> www.envoyproxy.io
there were a couple of reasons for shifting - one was that the google example stopped working (due to CSP i think) - where you request an
http
page that proxies to anhttps
pageat the time proxying to the www.envoyproxy.io domain worked fine
in recent tests i noticed that this is no longer the case - or at least more often than not it doesnt work - sometimes it does work
basically when you request over
http
you get a proxied response to 301 redirect tohttps
im not sure if something has changed in the website handling of headers, or whether the headers that envoy sends has changed - but either way it no longer works - wierdly it occasionally does work
this can be tested as follows
relevant config is here https://github.com/envoyproxy/envoy/blob/main/configs/envoyproxy_io_proxy.yaml
The text was updated successfully, but these errors were encountered: