Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.upstream_host_weight_change_causes_rebuild deprecation #18446

Closed
alyssawilk opened this issue Oct 5, 2021 · 0 comments · Fixed by #18555
Closed

envoy.reloadable_features.upstream_host_weight_change_causes_rebuild deprecation #18446

alyssawilk opened this issue Oct 5, 2021 · 0 comments · Fixed by #18555
Assignees
@mattklein123
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #14569 (upstream: force a full rebuild on host weight changes) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Oct 5, 2021
mattklein123 added a commit that referenced this issue Oct 11, 2021
@mattklein123
upstream: remove upstream_host_weight_change_causes_rebuild runtime
96d0f10 
Fixes #18446

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123 mattklein123 mentioned this issue Oct 11, 2021
Merged
mattklein123 added a commit that referenced this issue Oct 12, 2021
@mattklein123
upstream: remove upstream_host_weight_change_causes_rebuild runtime (#…
ae1b472 
…18555)

Fixes #18446

Signed-off-by: Matt Klein <mklein@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattklein123 mattklein123

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upstream: remove upstream_host_weight_change_causes_rebuild runtime envoyproxy/envoy
2 participants
@mattklein123 @alyssawilk