Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uhv: http-parser: allow extension methods #19757

Closed
ameily opened this issue Jan 31, 2022 · 2 comments
Closed

uhv: http-parser: allow extension methods #19757

ameily opened this issue Jan 31, 2022 · 2 comments
Assignees
Labels
area/http enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@ameily
Copy link
Contributor

ameily commented Jan 31, 2022

As part of the unified header validation component, http-parser needs to be updated to allow the use of extension methods, similar to how nghttp2 allows them. http-parser will be modified to add a new configuration setting that does not validate the method. This will allow similar behavior between the h1 and h2 codecs.

Within Envoy, a new configuration setting may need to be added as well that controls this behavior, outside of the UHV component or header validation policy.

This will need to be completed after http-parser has been brought into Envoy, #19749.

@ameily ameily added the triage Issue requires triage label Jan 31, 2022
@snowp snowp added enhancement Feature requests. Not bugs or questions. and removed triage Issue requires triage labels Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 6, 2022
@yanavlasov yanavlasov added area/http no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Mar 8, 2022
@yanavlasov yanavlasov self-assigned this Mar 8, 2022
@yanavlasov
Copy link
Contributor

UHV will not be used with http-parser and will only work with Balsa codec. This is no longer applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

3 participants