Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uhv: move http-parser to envoy #19749

Closed
Tracked by #20261
ameily opened this issue Jan 31, 2022 · 2 comments · Fixed by #19786
Closed
Tracked by #20261

uhv: move http-parser to envoy #19749

ameily opened this issue Jan 31, 2022 · 2 comments · Fixed by #19786
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@ameily
Copy link
Contributor

ameily commented Jan 31, 2022

Envoy will need to use a modified version of http-parser as part of the unified header validation component. The first step would be to bring in http-parser into Envoy. Then, as part of a separate issue, http-parser will be modified to add a configuration setting that skip header validation.

Right now, http-parser is built as an external library.
@ameily ameily added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jan 31, 2022
This was referenced Jan 31, 2022
Closed
Closed
Open
ameily added a commit to trail-of-forks/envoy that referenced this issue Feb 2, 2022
@ameily
integrate and use local copy of http-parser; refs envoyproxy#19749
97991ef 
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
@ameily ameily mentioned this issue Feb 2, 2022
Merged
@moderation
Copy link
Contributor

I thought the plan was to stop using the deprecated http-parser. See:

It looks like all of the uhv issues rely on bringing the deprecated code into Envoy?

@ameily
Copy link
Contributor Author

ameily commented Feb 3, 2022

We are working with Yan on the unified header validation component and he shared a technical specification to start working against, which I was under the impression had been approved. There is more discussion going on about this issue in the PR, #19786.

@snowp snowp removed the triage Issue requires triage label Feb 4, 2022
phlax pushed a commit that referenced this issue Feb 11, 2022
@ameily
deps: integrate and use local copy of http-parser library (#19786)
d3ecdce 
* integrate and use local copy of http-parser; refs #19749
* ignore third party dependency: http-parser
* exclude http-parser third-party code from clang-tidy

Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
joshperry pushed a commit to joshperry/envoy that referenced this issue Feb 13, 2022
@ameily
deps: integrate and use local copy of http-parser library (envoyproxy…
2376838 
…#19786)

* integrate and use local copy of http-parser; refs envoyproxy#19749
* ignore third party dependency: http-parser
* exclude http-parser third-party code from clang-tidy

Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Josh Perry <josh.perry@mx.com>
@yanavlasov yanavlasov mentioned this issue Mar 8, 2022
Open
7 tasks
@adisuissa adisuissa mentioned this issue Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: integrate and use local copy of http-parser library trail-of-forks/envoy
3 participants
@moderation @ameily @snowp