-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Envoy mobile code into the Envoy repo #23758
Comments
This PR sets up the directory structure, visibility rules, codeowners, adds E-M C++ tests to Envoy CI, and moves one extension over as a proof of concept. Risk Level: low Testing: ported test to Envoy CI. did not turn up platform CI yet Release Notes: inline Part of #23758 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Reverting #470 which is a patch to boringssl https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted. Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Part of envoyproxy/envoy#23758 Fixes #471 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Full repo merge. Push one: copied the entire envoy mobile repo into Envoy as is from d1350ec9a42077267c7b19348f49d4da5502d191 copied EM workflows into the Envoy workflow directory Push 2: change mobile/envoy to a symlink to the ../ envoy repo instead add a few files missed in push 1 several file fixups to pass lint (upstreamed in PR envoyproxy/envoy-mobile#2684) removing proto and absl patches from E-M edited EM workflows to run from the mobile directory and only run iff mobile/** paths changed (see diffs between first and second PR) -- disabling swift lint because I can't get it to work. -- disabling perf because it can't work on first check in (compares to clean head) -- release validation because it's having OS issues Risk Level: added EM CI Testing: new EM tests Docs Changes: n/a Release Notes: none most of #23758 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
perf turned up in (#24153) |
@jpsim @Augustyniak I think we're at a point we should flip source of truth to the Envoy repo, and do a weekly copy into the E-M repo until we fix up tagging and releases. I've snagged some time on JP's calendar to talk about it next week on the assumption he'll find a time that works and invite whoever is relevant on the Lyft side. |
Some other migration tasks that come to mind:
|
Related fix: #24228 |
Reverting #470 which is a patch to boringssl https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted. Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Part of #23758 Fixes #471 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
Part of #23758 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This is the CI job that's responsible for building the public website docs at https://envoymobile.io. Commit Message: mobile: add CircleCI docs generation CI job Additional Description: This is the CI job that's responsible for building the public website docs at https://envoymobile.io. Risk Level: Low Testing: In Envoy Mobile repo. Docs Changes: Yes :) Release Notes: None. Platform Specific Features: Only relevant to mobile. Part of #23758 Signed-off-by: JP Simard <jp@jpsim.com>
Done in #24407 |
This still needs to be done. We discussed this at last week's Envoy Mobile community call, but didn't come to a clear conclusion.
This was mostly done, GH Actions were disabled, a note was added to the readme saying the repo is archived. I haven't gone and fully marked the repo as archive using GitHub's tools because that would also lock down issues, and we're still using those for the time being. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
Let's close this. We can open new tickets if/when we want to fully archive the previous envoy-mobile repo or re-introduce deploy CI jobs. |
Almost all files are copied from envoy-mobile repo to envoy/mobile Source of truth for mobile changes is still envoy-mobile. @alyssawilk is doing updates until we flip source of truth to envoy/mobile.
TODO:
Thursday(ish) switch source of truth from envoy-mobile to envoy/mobile
Post-move
The text was updated successfully, but these errors were encountered: