Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_use_rfc_connect deprecation #25018

Closed
KBaichoo opened this issue Jan 18, 2023 · 0 comments
Closed

envoy_reloadable_features_use_rfc_connect deprecation #25018

KBaichoo opened this issue Jan 18, 2023 · 0 comments
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@KBaichoo
Copy link
Contributor

Your change #21440 (http: fixing up CONNECT to be RFC compliant) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@KBaichoo KBaichoo added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Jan 18, 2023
@alyssawilk alyssawilk mentioned this issue Jan 19, 2023
Merged
alyssawilk added a commit that referenced this issue Jan 23, 2023
@alyssawilk
http: removing reloadable flag use_rfc_connect (#25038)
14bf8cc 
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes [#25018]
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
VishalDamgude pushed a commit to freshworks/envoy that referenced this issue Feb 2, 2023
@alyssawilk @VishalDamgude
http: removing reloadable flag use_rfc_connect (envoyproxy#25038)
87c5940 
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes [envoyproxy#25018]
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KBaichoo @alyssawilk