Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable mobile tests on release branches #25205

Closed
phlax opened this issue Jan 27, 2023 · 5 comments · Fixed by #25209
Closed

Disable mobile tests on release branches #25205

phlax opened this issue Jan 27, 2023 · 5 comments · Fixed by #25209
Assignees
@jpsim
Labels
area/ci area/release mobile

Comments

@phlax
Copy link
Member

phlax commented Jan 27, 2023

The most recent release branch to fork (release/v1.25) carries the new mobile CI and has a high tendency towards failure

Im wondering if there is any reason we want these tests to run at all on release branches (altho im not 100% clear about if/how we can make it only target PRs -> main)
@phlax phlax added the triage Issue requires triage label Jan 27, 2023
@phlax phlax mentioned this issue Jan 27, 2023
Merged
@phlax phlax added area/ci area/release mobile and removed triage Issue requires triage labels Jan 27, 2023
@phlax
Copy link
Member Author

phlax commented Jan 27, 2023

cc @jpsim

@jpsim
Copy link
Contributor

jpsim commented Jan 27, 2023

mobile/tools/should_run_ci.sh should be able to check that we're running on a PR towards main. Or maybe the heuristic here is only to skip mobile CI jobs if the current branch name is in the format release-.*-dev so that it's still useful to have staged PRs touching mobile/**.

@phlax
Copy link
Member Author

phlax commented Jan 27, 2023

i dont want to impose a release-x branch name on all backport PRs but i guess we could automatically skip at that point and bail in the script if it gets that far

... it's still useful to have staged PRs touching mobile/**

im trying to figure out if that is useful - i think the release branches are only used for releasing envoy and mobile releases are handled separately - so trying to think if there is any benefit

@jpsim
Copy link
Contributor

jpsim commented Jan 27, 2023

im trying to figure out if that is useful - i think the release branches are only used for releasing envoy and mobile releases are handled separately - so trying to think if there is any benefit

I meant that if I make two PRs branch2 -> branch1 -> main it'd be good that the branch2 PR ran the mobile CI jobs if appropriate even if that PR isn't targeting a main base branch.

@phlax
Copy link
Member Author

phlax commented Jan 27, 2023

ah gotcha - yep we can filter on the target branch being release/v*

@jpsim jpsim self-assigned this Jan 27, 2023
@jpsim jpsim mentioned this issue Jan 27, 2023
Merged
phlax pushed a commit to phlax/envoy that referenced this issue Jan 27, 2023
@jpsim @phlax
mobile: skip Envoy Mobile CI jobs on PRs targeting release branches
df76636 
Addresses envoyproxy#25205

Signed-off-by: JP Simard <jp@jpsim.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
jpsim added a commit that referenced this issue Jan 27, 2023
@jpsim
mobile: skip Envoy Mobile CI jobs on PRs targeting release branches (#…
6e5024b 
…25209)

Addresses #25205

Signed-off-by: JP Simard <jp@jpsim.com>
phlax pushed a commit that referenced this issue Jan 27, 2023
@jpsim @phlax
mobile: skip Envoy Mobile CI jobs on PRs targeting release branches
ef10c60 
Addresses #25205

Signed-off-by: JP Simard <jp@jpsim.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
VishalDamgude pushed a commit to freshworks/envoy that referenced this issue Feb 2, 2023
@jpsim @VishalDamgude
mobile: skip Envoy Mobile CI jobs on PRs targeting release branches (e…
fa07134 
…nvoyproxy#25209)

Addresses envoyproxy#25205

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpsim jpsim

Labels
area/ci area/release mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mobile: skip Envoy Mobile CI jobs on PRs targeting release branches
2 participants
@phlax @jpsim