Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extensions/filters/http/cache:cache_filter_integration_test is flakey #26081

Closed
phlax opened this issue Mar 14, 2023 · 3 comments · Fixed by #26357
Closed

extensions/filters/http/cache:cache_filter_integration_test is flakey #26081

phlax opened this issue Mar 14, 2023 · 3 comments · Fixed by #26357
Assignees
@toddmgreer
Labels
area/cache area/test flakes bug no stalebot Disables stalebot from closing an issue
Milestone
Project green

Comments

@phlax
Copy link
Member

phlax commented Mar 14, 2023

this has been happening for a while and is pretty frequent

typical error:

[ RUN      ] Protocols/CacheIntegrationTest.ServeGetFromUpstreamAfterHeadRequest/IPv4_HttpDownstream_Http2UpstreamHttpParserNghttp2NoDeferredProcessing
test/integration/base_integration_test.cc:524: Failure
Value of: allow_excess_entries || entries.size() == entry + 1
  Actual: false
Expected: true
Waiting for entry index 0 but it was not the last entry as there were 2
- via_upstream
- via_upstream

Stack trace:
  0xb2f757: Envoy::BaseIntegrationTest::waitForAccessLog()
  0xaed40c: Envoy::Extensions::HttpFilters::Cache::(anonymous namespace)::CacheIntegrationTest_ServeGetFromUpstreamAfterHeadRequest_Test::TestBody()
  0x1db8a2c: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x1db88ed: testing::Test::Run()
  0x1db9b47: testing::TestInfo::Run()
... Google Test internal frames ...

https://dev.azure.com/cncf/envoy/_build/results?buildId=130668&view=logs&j=8c169225-0ae8-53bd-947f-07cb81846cb5&t=6b0ace90-28b2-51d9-2951-b1fd35e67dec&l=1642
@phlax phlax added this to the Project green milestone Mar 14, 2023
@phlax
Copy link
Member Author

phlax commented Mar 14, 2023

cc @ravenblackx

@alyssawilk
Copy link
Contributor

https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/131530/logs/337

@alyssawilk
Copy link
Contributor

https://dev.azure.com/cncf/envoy/_build/results?buildId=131603&view=logs&j=bbe4b42d-86e6-5e9c-8a0b-fea01d818a24&t=00ade0d6-ffae-5af0-b5e0-e33b1813c8bc

@alyssawilk alyssawilk added the no stalebot Disables stalebot from closing an issue label Mar 21, 2023
@alyssawilk alyssawilk mentioned this issue Mar 21, 2023
Merged
alyssawilk added a commit that referenced this issue Mar 21, 2023
@alyssawilk
test: disabling flaky tests until they can be debugged (#26213)
e599794 
Part of #26081

Part of #26182

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@toddmgreer toddmgreer mentioned this issue Mar 27, 2023
Merged
jmarantz pushed a commit that referenced this issue Mar 27, 2023
@toddmgreer
Fix issue 26213: cache_filter_integration_test is flakey. (#26357)
53f29dc 
Commit Message: Fix issue 26081: cache_filter_integration_test is flakey.
Additional Description: Test-only change
Risk Level: None
Testing: bazel test //test/extensions/filters/http/cache:cache_filter_integration_test --test_output=errors --runs_per_test=10000 --test_filter=Protocols/CacheIntegrationTest.ServeGetFromUpstreamAfterHeadRequest/*
Fixes #26081

Signed-off-by: Todd Greer <tgreer@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toddmgreer toddmgreer

Labels
area/cache area/test flakes bug no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
Project green
Development

Successfully merging a pull request may close this issue.

Fix issue 26213: cache_filter_integration_test is flakey. toddmgreer/envoy
3 participants
@phlax @alyssawilk @toddmgreer