Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDS delivered health status #2726

Closed
htuch opened this issue Mar 5, 2018 · 0 comments
Closed

EDS delivered health status #2726

htuch opened this issue Mar 5, 2018 · 0 comments
Assignees
@htuch
Labels
api/v2 enhancement Feature requests. Not bugs or questions. tech debt
Milestone
1.7.0

Comments

@htuch
Copy link
Member

htuch commented Mar 5, 2018

We added the ability to deliver health status for endpoints in the v2 API (https://github.com/envoyproxy/data-plane-api/blob/818dc1db99f73830b4f9be50c243d439e23555d6/envoy/api/v2/endpoint/endpoint.proto#L31). This can be used to provide centralized health checking and influence gentle failover between priority groups.

We have a requirement for this but it's not yet implemented, so will take this on.
@htuch htuch added enhancement Feature requests. Not bugs or questions. tech debt api/v2 labels Mar 5, 2018
@htuch htuch self-assigned this Mar 5, 2018
@mattklein123 mattklein123 added this to the 1.7.0 milestone Mar 5, 2018
@htuch htuch mentioned this issue Mar 22, 2018
Open
htuch added a commit to htuch/envoy that referenced this issue Mar 30, 2018
@htuch
eds: consume envoy::api::v2::core::HealthStatus settings for endpoints.
6692389 
Fixes envoyproxy#2726.

Risk Level: Low (no change unless the health status is explicitly set in
EDS response).
Testing: unit tests for eds.cc/upstream_impl.cc behavior, integration
test to validate end-to-end via eds_integration_test.cc.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch mentioned this issue Mar 30, 2018
Merged
htuch added a commit that referenced this issue Apr 2, 2018
@htuch
eds: consume envoy::api::v2::core::HealthStatus settings for endpoint…
c2ce08e 
…s. (#2948)

Fixes #2726.

Risk Level: Low (no change unless the health status is explicitly set in
EDS response).
Testing: unit tests for eds.cc/upstream_impl.cc behavior, integration
test to validate end-to-end via eds_integration_test.cc.

Signed-off-by: Harvey Tuch <htuch@google.com>
Shikugawa pushed a commit to Shikugawa/envoy that referenced this issue Mar 28, 2020
@bianpengyuan
Remove wasm binary file (envoyproxy#2726)
b6b1a8b 
* remove wasm file

* identation

* update target name to check_wasm

* add .wasm to git ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@htuch htuch

Labels
api/v2 enhancement Feature requests. Not bugs or questions. tech debt
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
2 participants
@mattklein123 @htuch