Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash protobufs with custom reflection rather than TextFormat #31276

Open
ravenblackx opened this issue Dec 11, 2023 · 2 comments
Open

Hash protobufs with custom reflection rather than TextFormat #31276

ravenblackx opened this issue Dec 11, 2023 · 2 comments
Assignees
@ravenblackx
Labels
area/protobuf no stalebot Disables stalebot from closing an issue

Comments

@ravenblackx
Copy link
Contributor

This is a tracking issue accompanying #30761

This is to keep track of upgrading and then removing the runtime guard envoy.restart_features.use_fast_protobuf_hash.
@ravenblackx ravenblackx added no stalebot Disables stalebot from closing an issue area/protobuf labels Dec 11, 2023
@ravenblackx ravenblackx self-assigned this Dec 11, 2023
@ravenblackx
Copy link
Contributor Author

ravenblackx commented Dec 11, 2023 •
edited
Loading

/remind me in three months to upgrade it to default-true.
Edit: guess we don't have that bot.

@howardjohn
Copy link
Contributor

/remind me in three months to upgrade it to default-true.
Edit: guess we don't have that bot.

Here is the human reminder 🙂 . Still interest in flipping this?

@ravenblackx ravenblackx mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravenblackx ravenblackx

Labels
area/protobuf no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@howardjohn @ravenblackx