Flip runtime guard on use_fast_protobuf_hash #33121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
juanmolle
approved these changes
Mar 26, 2024
juanmolle
reviewed
Mar 26, 2024
| @@ -108,6 +108,7 @@ RUNTIME_GUARD(envoy_restart_features_allow_client_socket_creation_failure); | |||
| RUNTIME_GUARD(envoy_restart_features_quic_handle_certs_with_shared_tls_code); | |||
| RUNTIME_GUARD(envoy_restart_features_send_goaway_for_premature_rst_streams); | |||
| RUNTIME_GUARD(envoy_restart_features_udp_read_normalize_addresses); | |||
| RUNTIME_GUARD(envoy_restart_features_use_fast_protobuf_hash); | |||
There was a problem hiding this comment.
I guess there is no UT to check default values, is that common?
There was a problem hiding this comment.
There are unit tests that test both true and false behaviors for this case - I made the unit tests force the values specifically so that changing the default wouldn't require updating the tests.
It may not be common, but I find it much less annoying than the other way.
|
gentle ping @jmarantz |
jmarantz
previously approved these changes
Apr 1, 2024
|
@yanavlasov for senior review. Also this seems possibly related to the equal/equivalent change in another PR so I wanted to make sure you were aware of the change this enables, which provides an efficient way to get an order-insensitive hash for maps. |
|
@ravenblackx needs main merge. |
|
Waiting for main merge /wait |
Signed-off-by: Raven Black <ravenblack@dropbox.com>
yanavlasov
approved these changes
Apr 1, 2024
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
--------- Signed-off-by: Raven Black <ravenblack@dropbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Flip runtime guard on use_fast_protobuf_hash
Additional Description: #31276
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]