Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io_uring tests not executed in coverage CI #32149

Closed
RyanTheOptimist opened this issue Feb 1, 2024 · 5 comments
Closed

io_uring tests not executed in coverage CI #32149

RyanTheOptimist opened this issue Feb 1, 2024 · 5 comments
Assignees
@soulxu
Labels
area/ci backport/review Request to backport to stable releases stale stalebot believes this issue/PR has not been touched recently

Comments

@RyanTheOptimist
Copy link
Contributor

Coverage CI is failing because coverage is too low in source/common/io. https://dev.azure.com/cncf/envoy/_build/results?buildId=161211&view=logs&jobId=4930ecaf-18f4-5b3c-dea3-309729c3b3ae&j=4930ecaf-18f4-5b3c-dea3-309729c3b3ae&t=573d8780-d7b9-52e3-b4e0-a89886b0b9ff @phlax tracked this down to a problem where this code is not being executed on our CI hosts.
@RyanTheOptimist RyanTheOptimist added the triage Issue requires triage label Feb 1, 2024
@RyanTheOptimist RyanTheOptimist mentioned this issue Feb 1, 2024
Merged
@phlax
Copy link
Member

phlax commented Feb 1, 2024

a problem where this code is not being executed on our CI hosts.

i think the problem is with the RBE workers

RyanTheOptimist added a commit that referenced this issue Feb 1, 2024
@RyanTheOptimist
coverage: lower coverage for source/common/io/ (#32150)
9f92f4c 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. #32149

Signed-off-by: Ryan Hamilton <rch@google.com>
@phlax
Copy link
Member

phlax commented Feb 6, 2024

this is also happening on release branches

/backport

@repokitteh-read-only repokitteh-read-only bot added the backport/review Request to backport to stable releases label Feb 6, 2024
@alyssawilk alyssawilk added area/build area/ci and removed triage Issue requires triage area/build labels Feb 6, 2024
phlax pushed a commit to phlax/envoy that referenced this issue Feb 6, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (envoyproxy#32150)
78a4f3c 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. envoyproxy#32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this issue Feb 6, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (envoyproxy#32150)
1d49885 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. envoyproxy#32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this issue Feb 6, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (envoyproxy#32150)
0060aab 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. envoyproxy#32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this issue Feb 6, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (envoyproxy#32150)
f064bbb 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. envoyproxy#32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this issue Feb 6, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (#32150)
f3a43c2 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. #32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this issue Feb 6, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (#32150)
7f8333a 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. #32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this issue Feb 6, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (#32150)
24a52ab 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. #32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this issue Feb 7, 2024
@RyanTheOptimist @phlax
coverage: lower coverage for source/common/io/ (#32150)
22195f3 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. #32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 7, 2024
@soulxu soulxu removed the stale stalebot believes this issue/PR has not been touched recently label Mar 8, 2024
SeanKilleen pushed a commit to SeanKilleen/envoy that referenced this issue Apr 3, 2024
@RyanTheOptimist @SeanKilleen
coverage: lower coverage for source/common/io/ (envoyproxy#32150)
4ce8c3b 
Coverage CI is failing because coverage is too low in source/common/io because CI is not executing io_uring code. envoyproxy#32149

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 7, 2024
@soulxu
Copy link
Member

soulxu commented Apr 8, 2024

This is fixed by setting the container as priviledged envoyproxy/envoy-build-tools#323

@soulxu soulxu closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulxu soulxu

Labels
area/ci backport/review Request to backport to stable releases stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@phlax @soulxu @alyssawilk @RyanTheOptimist