Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: remove StringMatcher-related singletons. #32792

Closed
ggreenway opened this issue Mar 8, 2024 · 0 comments · Fixed by #33072
Closed

Tech debt: remove StringMatcher-related singletons. #32792

ggreenway opened this issue Mar 8, 2024 · 0 comments · Fixed by #33072
Assignees
@ggreenway
Labels
tech debt

Comments

@ggreenway
Copy link
Contributor

Currently the Regex engine is stored in a singleton instead of being passed to where it is used. #32586 also would add more singletons for similar purpose.

This should be cleaned up, and a factory context with the appropriate objects should be passed to all locations that need these singletons.
@ggreenway ggreenway mentioned this issue Mar 8, 2024
Merged
@ggreenway ggreenway self-assigned this Mar 11, 2024
@ggreenway ggreenway mentioned this issue Mar 11, 2024
Merged
ggreenway added a commit that referenced this issue Mar 14, 2024
@ggreenway
Begin process of removing singleton use by StringMatcher (#32829)
b7818b0 
Part of #32792

Signed-off-by: Greg Greenway <ggreenway@apple.com>
This was referenced Mar 15, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggreenway ggreenway

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stringmatcher: cleanup temporary code ggreenway/envoy
1 participant
@ggreenway