-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of bypass overload manager flag to envoy 1.29 #35985
Comments
cc @nezdolik @singamL887 if you raise a PR im happy to review it |
I created a PR for this since I am the author of the change in main. |
@cancecen you are creating backport because is not possible to upgrade to latest version (where this feature is included)? |
@nezdolik I am not sure - I am not working with the author of this issue, I just wanted to address this since I am the author of the original PR. |
i should have asked when i first saw the ticket - is the backport a fix - we dont usually backport features |
It's not really a fix - it's an enhancement on the existing overload manager functionality. Let me know how you want to proceed here, I can close my backport PR (linked above). |
tbh, then i think its not covered by our support/stable branches policy, and best way forward is to close |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions. |
Title: One line description
Backport of bypass_overload_manager flag to envoy 1.29
Description:
bypass_overload_manager flag bypasses probes from overload manager stop_accepting_connections/requests actions when envoy reached the configured heap limit.
briansonnenberg@96a43c3
Backporting it to the envoy v1.29
[optional Relevant Links:]
#23843
The text was updated successfully, but these errors were encountered: