Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of bypass overload manager flag to envoy 1.29 #35985

Closed
singamL887 opened this issue Sep 5, 2024 · 9 comments
Closed

Backport of bypass overload manager flag to envoy 1.29 #35985

singamL887 opened this issue Sep 5, 2024 · 9 comments
Labels
area/overload_manager backport/review Request to backport to stable releases enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@singamL887
Copy link

singamL887 commented Sep 5, 2024

Title: One line description
Backport of bypass_overload_manager flag to envoy 1.29

Description:
bypass_overload_manager flag bypasses probes from overload manager stop_accepting_connections/requests actions when envoy reached the configured heap limit.

briansonnenberg@96a43c3

Backporting it to the envoy v1.29

[optional Relevant Links:]

#23843

@singamL887 singamL887 added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Sep 5, 2024
@phlax phlax added backport/review Request to backport to stable releases area/overload_manager and removed triage Issue requires triage labels Sep 6, 2024
@phlax
Copy link
Member

phlax commented Sep 6, 2024

cc @nezdolik

@singamL887 if you raise a PR im happy to review it

@cancecen
Copy link
Contributor

I created a PR for this since I am the author of the change in main.

@nezdolik
Copy link
Member

@cancecen you are creating backport because is not possible to upgrade to latest version (where this feature is included)?

@cancecen
Copy link
Contributor

@nezdolik I am not sure - I am not working with the author of this issue, I just wanted to address this since I am the author of the original PR.

@phlax
Copy link
Member

phlax commented Sep 11, 2024

i should have asked when i first saw the ticket - is the backport a fix - we dont usually backport features

@cancecen
Copy link
Contributor

It's not really a fix - it's an enhancement on the existing overload manager functionality. Let me know how you want to proceed here, I can close my backport PR (linked above).

@phlax
Copy link
Member

phlax commented Sep 12, 2024

It's not really a fix - it's an enhancement

tbh, then i think its not covered by our support/stable branches policy, and best way forward is to close

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 12, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/overload_manager backport/review Request to backport to stable releases enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

4 participants