Backport #34322 to release/v1.29. #36064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to bypass overload manager for listeners (envoyproxy#34322) Commit Message: Add the ability to bypass overload manager for listeners Additional Description: This flag can be used to disable overload manager on specific listeners where, for instance, we don't want to stop accepting requests. In my company, we implemented a CPU Utilization resource monitor that helps us drop requests when we hit a certain utilization percentage, but there are certain listeners that receive administrative traffic that we don't want overload manager to touch. Another use case is, we want to only throttle ingress traffic but not egress traffic going via Envoy. Another contributor authored envoyproxy#29781, but it has been marked as stale. Risk Level: Low Testing: Unit tests & Integration tests added Docs Changes: No Release Notes: Add bypass_overload_manager flag to Listener in order to prevent overload manager from taking actions on the traffic going through the said listener. Platform Specific Features: Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com> Signed-off-by: Can Cecen <ccecen@netflix.com> Signed-off-by: Can Cecen <cecen.ycan@gmail.com>
cancecen
requested review from
RyanTheOptimist,
alyssawilk,
abeyad,
ggreenway,
soulxu,
yanavlasov,
mattklein123,
kyessenov and
adisuissa
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Can Cecen <ccecen@netflix.com>
|
/lgtm api |
|
Looks like this fails to build? |
nezdolik
reviewed
Sep 11, 2024
| }); | ||
| initialize(); | ||
| updateResource(0); | ||
| } |
There was a problem hiding this comment.
may have forgotten to port TEST_P(LoadShedPointIntegrationTest, HttpConnManagerDoesNotShedLoadWhenBypassed)?
|
Closing this per #35985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #35985.
Original Commit Message:
Add the ability to bypass overload manager for listeners (#34322)
Commit Message: Add the ability to bypass overload manager for listeners
Additional Description: This flag can be used to disable overload manager on specific listeners where, for instance, we don't want to stop accepting requests. In my company, we implemented a CPU Utilization resource monitor that helps us drop requests when we hit a certain utilization percentage, but there are certain listeners that receive administrative traffic that we don't want overload manager to touch. Another use case is, we want to only throttle ingress traffic but not egress traffic going via Envoy. Another contributor authored #29781, but it has been marked as stale.
Risk Level: Low
Testing: Unit tests & Integration tests added
Docs Changes: No
Release Notes: Add bypass_overload_manager flag to Listener in order to prevent overload manager from taking actions on the traffic going through the said listener. Platform Specific Features: