Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing timing information to Hystrix event stream output #3753

Closed
trabetti opened this issue Jun 28, 2018 · 3 comments
Closed

Add missing timing information to Hystrix event stream output #3753

trabetti opened this issue Jun 28, 2018 · 3 comments
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@trabetti
Copy link
Contributor

trabetti commented Jun 28, 2018 •
edited
Loading

Title: Add missing timing information to Hystrix event stream output

Description:
The Hystrix event stream support that was added in #3425 do not include timing information. It is hopefully possible to use the histogram support added in #3130 for that.

The timing information can be seen here at the bottom part below the circle of traffic for each service: Hystrix dashboard wiki
@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Jun 28, 2018
@stale
Copy link

stale bot commented Jul 28, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 28, 2018
@trabetti trabetti mentioned this issue Jul 30, 2018
Merged
@stale
Copy link

stale bot commented Aug 4, 2018

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Aug 4, 2018
@trabetti
Copy link
Contributor Author

trabetti commented Aug 5, 2018

@mattklein123 can you please re-open, this issue is being fixed by #3986.

@dio dio reopened this Aug 5, 2018
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Aug 5, 2018
htuch pushed a commit that referenced this issue Aug 29, 2018
@trabetti @htuch
added histogram latency information to Hystrix dashboard stream (#3986)
3b47cba 
Adding the latency information from existing histogram to Hystrix event stream that was added in #3425
Risk Level: Low
Testing:
Docs Changes: admin.rst
Release Notes: No addition to release note of original Hystrix stream PR, which is still pending for 1.8.0
Fixes #3753

Signed-off-by: trabetti <talis@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dio @mattklein123 @trabetti