Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Extend drop-overload to include overload category #3823

Closed
vishalpowar opened this issue Jul 9, 2018 · 3 comments
Closed

Feature Request: Extend drop-overload to include overload category #3823

vishalpowar opened this issue Jul 9, 2018 · 3 comments
Labels
design proposal Needs design doc/proposal before implementation

Comments

@vishalpowar
Copy link
Contributor

Traffic drop request is provided to envoy as part of eds.ClusterLoadAssignment.policy.drop_overload
This along with lrs.ClusterStats.total_dropped_requests can be used as feedback loop to rate-limit traffic from envoy and check if it is having desired effect by a Central control system.

In v2 proto the expectation is that there is one Central control system which will generate this drop request and will use the feedback.
The Central control system could potentially generate drop_overload for various reasons

  • Load balancing feedback to prevent a client from overloading servers.
  • Centralized Quota/Rate management, requesting client to dial-back based on policies.

Fine grain control over specifying the type of 'drop_overload' and its feedback 'dropped_requests' can help provide better management and control.

More details + proposal for change.

https://docs.google.com/document/d/1gZENz8GZOo1-uvA299_Kxbo3D1XYg0fPbR0Ac_x9I_w/edit?usp=sharing
@htuch htuch added the design proposal Needs design doc/proposal before implementation label Jul 10, 2018
@htuch
Copy link
Member

htuch commented Jul 10, 2018

@mattklein123 @amb67 @alyssawilk for review.

@mattklein123
Copy link
Member

I added one comment but sounds fine to me. My main comment is that given drop_overload is not implemented yet, let's just replace it entirely with the more flexible scheme with some notion of default category or something like that.

@htuch
Copy link
Member

htuch commented Jul 17, 2018

LGTM

@vishalpowar vishalpowar mentioned this issue Jul 19, 2018
Merged
vishalpowar added a commit to vishalpowar/envoy that referenced this issue Jul 25, 2018
@vishalpowar
Add support for drop category policy and reporting
6839b73 
This PR contains changes to implement feature requested in issue envoyproxy#3823
 - Adding DropOverload in eds policy which can be used to specify
 drop_percentage per category.
 - Adding DroppedRequests in load_report which can report deliberately
 dropped requests for each category.

Signed-off-by: vishalpowar <vishal.powar@gmail.com>
zuercher pushed a commit that referenced this issue Jul 25, 2018
@vishalpowar @zuercher
Add support for drop category policy and reporting (#3894)
3ee3aa3 
This PR contains changes to implement feature requested in issue #3823
 - Adding DropOverload in eds policy which can be used to specify
 drop_percentage per category.
 - Adding DroppedRequests in load_report which can report deliberately
 dropped requests for each category.

Signed-off-by: vishalpowar <vishal.powar@gmail.com>
@yanjunxiang-google yanjunxiang-google mentioned this issue Nov 10, 2023
Merged
@yanjunxiang-google yanjunxiang-google mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design proposal Needs design doc/proposal before implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vishalpowar @mattklein123 @htuch