Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryParams should be a real class with correct parsing & serialization #4142

Closed
jmarantz opened this issue Aug 14, 2018 · 4 comments
Closed
Assignees
Labels
stale stalebot believes this issue/PR has not been touched recently tech debt

Comments

@jmarantz
Copy link
Contributor

Description:

QueryParams are just a map, but there's no central control or testing of parsing, serialization, escaping, etc.

See TODO in https://github.com/envoyproxy/envoy/blob/master/include/envoy/http/query_params.h

This may help ultimately with #2098 , though I personally don't understand the context for that particular enhancement request.

@rotan96 may look at this.

@stale
Copy link

stale bot commented Sep 19, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 19, 2018
@rotan96
Copy link
Contributor

rotan96 commented Sep 19, 2018

Hi stale bot I am working on this (how do I un-stale this)

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Sep 19, 2018
rotan96 added a commit to rotan96/envoy that referenced this issue Sep 20, 2018
This fixes envoyproxy#4142.

Signed-off-by: Robin Tan <rotan@google.com>
@stale
Copy link

stale bot commented Oct 19, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 19, 2018
@stale
Copy link

stale bot commented Oct 26, 2018

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR has not been touched recently tech debt
Projects
None yet
Development

No branches or pull requests

3 participants