Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HeaderMap uses of c_str #6494

Closed
dnoe opened this issue Apr 5, 2019 · 0 comments · Fixed by #6564
Closed

Remove HeaderMap uses of c_str #6494

dnoe opened this issue Apr 5, 2019 · 0 comments · Fixed by #6564
Assignees
@dnoe
Labels
tech debt
Milestone
1.11.0

Comments

@dnoe
Copy link
Contributor

dnoe commented Apr 5, 2019 •
edited
Loading

Description:

Following up on #6434 eliminate users of HeaderMap c_str() and convert all to absl::string_view.

Action item for CVE-2019-9900
@dnoe dnoe self-assigned this Apr 5, 2019
@mattklein123 mattklein123 added this to the 1.11.0 milestone Apr 5, 2019
This was referenced Apr 12, 2019
Merged
Open
lizan pushed a commit that referenced this issue Apr 16, 2019
@dnoe @lizan
Remove HeaderString::c_str() and migrate callers to getStringView() (#…
3a596a4 
…6564)

Remove the `HeaderString::c_str()` API, and migrate all callers of it to `getStringView()` and `string_view` style usage (ie, `absl::string_view::find` instead of C style comparisons) wherever appropriate.

Risk Level: Medium. No logic changes intended, but this is delicate and risky code and a large portion of the code base was touched.
Testing: `bazel test //test/...`
Docs Changes: None
Release Notes: None
Fixes #6494

Signed-off-by: Dan Noé <dpn@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnoe dnoe

Labels
tech debt
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

Remove HeaderString::c_str() and migrate callers to getStringView() dnoe/envoy
2 participants
@dnoe @mattklein123