Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Connection: combine SSL_set_ex_data and SSL_set_app_data #9867

Open
jimini-lumox opened this issue Jan 29, 2020 · 2 comments
Open

SSL Connection: combine SSL_set_ex_data and SSL_set_app_data #9867

jimini-lumox opened this issue Jan 29, 2020 · 2 comments
Assignees

Comments

@jimini-lumox
Copy link
Contributor

Title: Combine SSL Connection's SSL_set_ex_data and SSL_set_app_data

Description:
PR #9172 introduces additional SSL_set_ex_data to be able to update SslExtendedSocketInfo during SSL validation.
This issue is to refactor the new SSL_set_ex_data and existing SSL_set_app_data to combine to a single SSL_set_app_data.

Currently:
SSL_set_app_data: The ContextImpl's const Network::TransportSocketOptions* options set by the ContextImpl but only if (options && !options->verifySubjectAltNameListOverride().empty()) when the SslSocket is created
SSL_set_ex_data: The SslSocketInfo::SslExtendedSocketInfo member set when the SslSocket is subsequently moved to be owned by the constructed SslSocketInfo

@lizan
Copy link
Member

lizan commented Jan 29, 2020

/assign jimini-lumox

@repokitteh-read-only
Copy link

jimini-lumox cannot be assigned to this issue.

🐱

Caused by: a #9867 (comment) was created by @lizan.

see: more, trace.

@mattklein123 mattklein123 added area/tls tech debt no stalebot Disables stalebot from closing an issue labels Feb 5, 2020
@mattklein123 mattklein123 added help wanted Needs help! and removed no stalebot Disables stalebot from closing an issue labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants