utility: convert typed_config to factory config #10418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Xue <yxyan@google.com>
htuch
reviewed
Mar 17, 2020
| */ | ||
| template <class Factory> | ||
| static ProtobufTypes::MessagePtr | ||
| translateAnyToFactoryConfig(const ProtobufWkt::Any& typed_config, |
There was a problem hiding this comment.
Thanks, this looks clean. Are there some existing sites that we should refactor to use this?
There was a problem hiding this comment.
I didn't do a thorough search but I guess existing proto should include the deprecated config field. Otherwise, this function should exist for converting the typed config to factory configuration.
We could replace all the translateToFactoryConfig with translateAnyToFactoryConfig because the config field is deprecated. It will break the compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yan Xue yxyan@google.com
Description: convert typed_config to factory config
Risk Level: Low
Testing: Unit test
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]