access log: make %DOWNSTREAM_DIRECT_REMOTE_ADDRESS% work correctly with PROXY protocol #10419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th PROXY protocol Previously, this access log field would return the value read from the PROXY protocol header instead of using the direct address, as documented. Fixes: envoyproxy#10328 Signed-off-by: Greg Greenway <ggreenway@apple.com>
ggreenway
requested review from
alyssawilk,
lizan,
mattklein123 and
zuercher
as code owners
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
zuercher
previously approved these changes
Mar 18, 2020
| @@ -92,6 +92,32 @@ TEST_P(ProxyProtoIntegrationTest, RouterProxyUnknownLongRequestAndResponseWithBo | |||
| testRouterRequestAndResponseWithBody(1024, 512, false, &creator); | |||
| } | |||
|
|
|||
| // Test that %DOWNSTREAM_DIRECT_REMOTE_ADDRESS*% returns the direct address, and | |||
There was a problem hiding this comment.
I added that to note that it also applies to DOWNSTREAM_DIRECT_REMOTE_ADDRESS_WITHOUT_PORT, but maybe I should just enumerate the two.
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this access log field would return the value read from the
PROXY protocol header instead of using the direct address, as
documented.
Risk Level: Low
Testing: Added integration test
Docs Changes: none
Release Notes: added
Fixes #10328