request_id_extension: Add noop impl by default #10687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruslan Nigmatullin <elessar@dropbox.com>
mattklein123
requested changes
Apr 7, 2020
mattklein123
previously approved these changes
Apr 8, 2020
| namespace { | ||
|
|
||
| // NoopRequestIDExtension is the implementation used outside of HTTP context. | ||
| class NoopRequestIDExtension : public RequestIDExtension { |
There was a problem hiding this comment.
nit: it would be nice to get coverage of the other methods here in the unit test you added.
| @@ -20,12 +21,14 @@ struct StreamInfoImpl : public StreamInfo { | |||
| StreamInfoImpl(TimeSource& time_source) | |||
| : time_source_(time_source), start_time_(time_source.systemTime()), | |||
| start_time_monotonic_(time_source.monotonicTime()), | |||
| filter_state_(std::make_shared<FilterStateImpl>(FilterState::LifeSpan::FilterChain)) {} | |||
| filter_state_(std::make_shared<FilterStateImpl>(FilterState::LifeSpan::FilterChain)), | |||
| request_id_extension_(Http::RequestIDExtensionFactory::noopInstance()) {} | |||
There was a problem hiding this comment.
looking at this, I think these constructors can mostly be collapsed with each one invoking the previous with fewer arguments. This would be a nice follow up.
There was a problem hiding this comment.
Sounds good, will send a follow up pr. Does it need a TODO for the time being?
There was a problem hiding this comment.
Created #10691, will rebase once this one is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: By default use noop
RequestIDExtensionimplementation inStreamInfo. This allows avoiding nullptr checks outside of HTTP context.Risk Level: low
Testing: added unit test, updated integration test (crashes without
StreamInfoImplchanges)Docs Changes: n/a
Release Notes: n/a
Fixes #10686