Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: clarify how configuration is passed #10782

Merged
merged 9 commits into from
Apr 22, 2020
Merged

wasm: clarify how configuration is passed #10782

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5c07eb
add api clarification
kyessenov Apr 15, 2020
27d0595
Merge remote-tracking branch 'upstream/master' into update_wasm_exten…
kyessenov Apr 21, 2020
0a54834
mention bytes and string value
kyessenov Apr 21, 2020
d29834a
typo
kyessenov Apr 21, 2020
2f5a784
delete wasm v2alpha
kyessenov Apr 21, 2020
10f7c94
nuke v2alpha
kyessenov Apr 21, 2020
bc0c2ad
no v3 for extensions yet
kyessenov Apr 21, 2020
5aaef09
remove wasm dir
kyessenov Apr 22, 2020
283d608
oops
kyessenov Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion api/envoy/extensions/wasm/v3/wasm.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ message VmConfig {
// The Wasm code that Envoy will execute.
config.core.v3.AsyncDataSource code = 3;

// The Wasm configuration used in initialization of a new VM (proxy_on_start).
// The Wasm configuration used in initialization of a new VM
// (proxy_on_start). `google.protobuf.Struct` is serialized as JSON before
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use name proxy_on_vm_start instead of proxy_on_start for consistency with https://github.com/proxy-wasm/spec/tree/master/abi-versions/vNEXT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave the naming for later? It's guaranteed to churn endlessly and will only freeze when the code lands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

// passing it to the plugin. `google.protobuf.BytesValue` and
// `google.protobuf.StringValue` are passed directly without the wrapper.
google.protobuf.Any configuration = 4;

// Allow the wasm file to include pre-compiled code on VMs which support it.
Expand Down Expand Up @@ -70,6 +73,9 @@ message PluginConfig {

// Filter/service configuration used to configure or reconfigure a plugin
// (proxy_on_configuration).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use name proxy_on_configure instead of proxy_on_configuration for consistency with https://github.com/proxy-wasm/spec/tree/master/abi-versions/vNEXT

// `google.protobuf.Struct` is serialized as JSON before
// passing it to the plugin. `google.protobuf.BytesValue` and
// `google.protobuf.StringValue` are passed directly without the wrapper.
google.protobuf.Any configuration = 5;
}

Expand Down
8 changes: 7 additions & 1 deletion generated_api_shadow/envoy/extensions/wasm/v3/wasm.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.