Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hiding of virtual function in FilterChainBenchmarkFixture #10850

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

nezdolik
Copy link
Member

Currently Setup function in FilterChainBenchmarkFixture is hiding virtual function in parent class benchmark::Fixture :

   virtual void SetUp(State& st) { SetUp(const_cast<const State&>(st)); }
                ^~~~~
test/server/filter_chain_benchmark_test.cc:169:8: error:   by 'virtual void Envoy::Server::FilterChainBenchmarkFixture::SetUp(const benchmark::State&)' [-Werror=overloaded-virtual]
   void SetUp(const ::benchmark::State& state) override {
        ^~~~~

Risk Level: Low
Testing: Covered by existing tests

Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
@mattklein123 mattklein123 merged commit 5b7d3af into envoyproxy:master Apr 20, 2020
penguingao pushed a commit to penguingao/envoy that referenced this pull request Apr 22, 2020
Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
Signed-off-by: pengg <pengg@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants