ip tagging: remember tags as builtins #10856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
|
cc: @jmarantz |
jmarantz
reviewed
Apr 20, 2020
I think the question didn't make it through... |
jmarantz
reviewed
Apr 20, 2020
| hit_(stat_name_set_->add("hit")), no_hit_(stat_name_set_->add("no_hit")), | ||
| total_(stat_name_set_->add("total")) { | ||
| no_hit_(stat_name_set_->add("no_hit")), total_(stat_name_set_->add("total")), | ||
| unknown_tag_(stat_name_set_->add("unknown_tag.hit")) { |
There was a problem hiding this comment.
I had thought what we could do was walk through the tags and add all of them as builtins so we don't map them all to unknown. Was there some reason you didn't want to do it that way?
There was a problem hiding this comment.
Eh?
I am doing that, in the loop that discovers the tags... the unknown_tag_ is needed because getBuiltin() needs a fallback parameter...
rgs1
commented
Apr 20, 2020
| tag_data.emplace_back(ip_tag.ip_tag_name(), cidr_set); | ||
| stat_name_set_->rememberBuiltin(absl::StrCat(ip_tag.ip_tag_name(), ".hit")); |
There was a problem hiding this comment.
@jmarantz here we add each tag...
There was a problem hiding this comment.
Sorry; my bad. OK this looks great! Thanks!
jmarantz
approved these changes
Apr 20, 2020
| tag_data.emplace_back(ip_tag.ip_tag_name(), cidr_set); | ||
| stat_name_set_->rememberBuiltin(absl::StrCat(ip_tag.ip_tag_name(), ".hit")); |
There was a problem hiding this comment.
Sorry; my bad. OK this looks great! Thanks!
penguingao
pushed a commit
to penguingao/envoy
that referenced
this pull request
Apr 22, 2020
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: pengg <pengg@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com